Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vm live test: allow more valid power states on vmss test verifications #2564

merged 2 commits into from Mar 21, 2017


Copy link

commented Mar 20, 2017

No description provided.

@yugangw-msft yugangw-msft changed the title vm live test: allow more valid states after vmss command execution vm live test: allow more valid power states on vmss test verifications Mar 20, 2017

This comment has been minimized.

Copy link

commented Mar 20, 2017

Codecov Report

Merging #2564 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2564   +/-   ##
  Coverage   72.29%   72.29%           
  Files         363      363           
  Lines       19832    19832           
  Branches     2923     2923           
  Hits        14338    14338           
  Misses       4580     4580           
  Partials      914      914

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67d44a1...1e52ba0. Read the comment docs.

@yugangw-msft yugangw-msft requested a review from troydai Mar 21, 2017
@yugangw-msft yugangw-msft force-pushed the yugangw-msft:live3 branch from 995cc6c to ea618d4 Mar 21, 2017
Copy link

left a comment

Besides the comments, I approve this pull request.

@@ -1656,10 +1656,10 @@ def set_up(self):
def test_vmss_vms(self):

def _check_vms_power_state(self, expected_power_state):
def _check_vms_power_state(self, expected_power_states):

This comment has been minimized.

Copy link

troydai Mar 21, 2017


The following definition can make the usage easier:

def _check_vms_power_state(self, *args):

The client will look like:

self._check_vms_power_state('PowerState/running', 'PowerState/starting')

This save the extra step to create a list.

Besides, I don't think the method has to initialize with _. It is meaningless given this is merely a test case.

@yugangw-msft yugangw-msft force-pushed the yugangw-msft:live3 branch from a3833b8 to 1e52ba0 Mar 21, 2017
@yugangw-msft yugangw-msft merged commit 1b7ddaa into Azure:master Mar 21, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
@yugangw-msft yugangw-msft deleted the yugangw-msft:live3 branch Mar 21, 2017
thegalah pushed a commit to thegalah/azure-cli that referenced this pull request Mar 21, 2017
* Azure/master: (478 commits)
  vm live test: allow more valid power states on vmss test verifications (Azure#2564)
  rbac:catch more graph error (Azure#2567)
  appservice: support to create plan when create a webapp (Azure#2550)
  Update storage tests (Azure#2556)
  Change PEP8 check filter from whitelist to blacklist (Azure#2557)
  Add scenario tests documentation (Azure#2555)
  [ACS] Adding support for configuring a default ACS cluster (Azure#2554)
  [ACS] Provide a short name alias for the orchestrator type flag (Azure#2553)
  Sql Import/Export CLI commands and test (Azure#2538)
  Fix format bug. (Azure#2549)
  [VM/VMSS] Improved disk caching support (Azure#2522)
  VM/VMSS: incorporate credentials validation logic used by portal (Azure#2537)
  Script that creates packaged releases package archive (Azure#2508)
  Adding alias for defaults flag (Azure#2540)
  Add wait commands and --no-wait support (Azure#2524)
  choice list outside of named arguments (Azure#2521)
  Fixed test failure in test_sql_db_mgmt. (Azure#2530)
  core: support login using service principal with a cert (Azure#2457)
  Add note about being in preview (Azure#2512)
  vm:fix distro check mechanism used by disk encryption (Azure#2511)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
4 participants
You can’t perform that action at this time.