Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create-for-rbac: ensure SP's end date will not exceed certificate's expiration date #2990

Merged
merged 4 commits into from
Apr 25, 2017

Conversation

yugangw-msft
Copy link
Contributor

Fix #2989

General Guidelines

  • The PR has modified HISTORY.rst with an appropriate description of the change (see Modifying change log).

Command Guidelines

  • Each command and parameter has a meaningful description.
  • Each new command has a test.

(see Authoring Command Modules)

@codecov-io
Copy link

codecov-io commented Apr 25, 2017

Codecov Report

Merging #2990 into master will increase coverage by <.01%.
The diff coverage is 55.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2990      +/-   ##
==========================================
+ Coverage   63.36%   63.37%   +<.01%     
==========================================
  Files         463      463              
  Lines       26599    26621      +22     
  Branches     4087     4092       +5     
==========================================
+ Hits        16854    16870      +16     
- Misses       8628     8633       +5     
- Partials     1117     1118       +1
Impacted Files Coverage Δ
...cli-role/azure/cli/command_modules/role/_params.py 100% <100%> (ø) ⬆️
...-cli-role/azure/cli/command_modules/role/custom.py 35.01% <53.12%> (+1.9%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bf3245...766b170. Read the comment docs.

Copy link
Member

@tjprescott tjprescott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. cc/ @devigned

@yugangw-msft yugangw-msft merged commit 74e5aac into Azure:master Apr 25, 2017
@yugangw-msft yugangw-msft deleted the certdate branch April 25, 2017 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants