Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`storage blob/file delete-batch` commands #4781

Merged
merged 6 commits into from Oct 30, 2017

Conversation

Projects
None yet
2 participants
@williexu
Copy link
Contributor

commented Oct 30, 2017


Closes: #3757

delete-batch commands will delete multiple files/blobs using a pattern to glob
deletes will use the same connection and hence be faster then running a delete command for each file/blob.

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • [y ] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

Command Guidelines

  • [y ] Each command and parameter has a meaningful description.
  • [y ] Each new command has a test.

(see Authoring Command Modules)

@williexu williexu requested a review from troydai as a code owner Oct 30, 2017

@troydai
Copy link
Contributor

left a comment

Looks good.

- name: --if-match
type: string
short-summary: An ETag value, or the wildcard character (*). Specify this header to perform the operation \
only if the resource's ETag matches the value specified.

This comment has been minimized.

Copy link
@troydai

troydai Oct 30, 2017

Contributor

you don't have to break the line.

short-summary: The pattern used for file globbing. The supported patterns are '*', '?', '[seq]', and '[!seq]'.
- name: --dryrun
type: bool
short-summary: List the files and blobs to be deleted. No actual data transfer will occur.

This comment has been minimized.

Copy link
@troydai

troydai Oct 30, 2017

Contributor

This is not data transfer but data deletion

logger.warning(' container %s', source_container_name)
logger.warning(' total %d', len(source_blobs))
logger.warning(' operations')
for blob in source_blobs or []:

This comment has been minimized.

Copy link
@troydai

troydai Oct 30, 2017

Contributor

The source_blobs can't be None. The or [] fallback is necessary.

@williexu williexu merged commit 3c63514 into Azure:dev Oct 30, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details

@williexu williexu deleted the williexu:deletebatch branch Jul 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.