Fix 'azdev test' automation and storage stack tests #7182
Conversation
tools/automation/tests/__init__.py
Outdated
| '2017-03-09-profile': 'profile_2017_03_09', | ||
| '2018-03-01-hybrid': 'hybrid_2018_03_01', | ||
| 'latest': 'latest' | ||
| } |
There was a problem hiding this comment.
This is just one more thing to maintain. These follow a consistent pattern, why not just special-case latest and for the others, do the dash to underscore replacement and move the end word to the beginning.
tools/automation/tests/__init__.py
Outdated
| @@ -177,7 +181,7 @@ def discover_tests(args): | |||
|
|
|||
| CORE_EXCLUSIONS = ['command_modules', '__main__', 'testsdk'] | |||
|
|
|||
| profile = args.profile.replace('-', '_') | |||
| profile_namespace = PROFILE_TO_NAMESPACE[args.profile] | |||
There was a problem hiding this comment.
This will crash when a new profile is added that doesn't get added to the PROFILE_TO_NAMESPACE dictionary (which is pretty likely). If you stick with this, at least catch the error and throw a friendly error to direct the dev to add the profile to the dictionary.
Another alternative would be to have this as part of the standard "shared.py" file in azure.cli.core.profiles. This makes it less likely a profile will be added without this.
|
@tjprescott made the change |
Fixes: #7179
Moved storage_test_util into tests from within profiles.