fix: parse subnet cidr and calculate gateway #1064
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Prior to this change, we parsed the subnet string into a byte array as
[1].[2].[3].[4], then built the gateway address for our netns by dropping[4]and replacing it with.1, as[1].[2].[3].1. This doesn't work for subnets that begin on a non-zero final octect, such as10.0.0.128/27, which should have a gateway address of10.0.0.129.This change updates the relevant code to calculate the gateway address as the first available IP in the provided subnet, fixing these bugs.
Along the way, it also:
Issue Fixed:
Requirements:
Notes: