feat: [NPM] Support pod grace period for v2 #1095
Merged
+183
−141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JungukCho
requested review from
huntergregory,
matmerr,
neaggarwMS and
vakalapa
Contributor
huntergregory
left a comment
huntergregory
left a comment
There was a problem hiding this comment.
Looks good if k8slabels.Equals() has community support
huntergregory
approved these changes
Nov 10, 2021
matmerr
pushed a commit
to matmerr/azure-container-networking
that referenced
this pull request
Nov 11, 2021
* Use official k8s equals functions for label instead of our own implementation * Update v2 pod controller to support graceful shutdown of pod
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
PodController in NPM removes ipset information as soon as Pod's status becomes “Terminating”.
So, even though terminated Pod has some activities (e.g., sending traffic to other pods to notify something) during "Terminating" status, NPM does not allow this connection from the Pod.
Thus, NPM needs to delay cleanup process until Pod completes graceful shutdown.
Issue Fixed:
Fixes #1066
Requirements:
support-pod-grace-perioddirectory in acndocNotes:
Previous PR for v1 - feat: [NPM] Support graceful shutdown in pod #1083