feat: [CNI] Enable DSR policy for windows singletenancy (AKS) by default #1116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamilmani1989
changed the title
tamilmani1989
changed the title
removed unused error
tamilmani1989
force-pushed
the
tamanoha/windows_dsr
branch
from
9ab98fc to
f86a0a2
Compare
AbelHu
previously approved these changes
Nov 19, 2021
tamilmani1989
force-pushed
the
tamanoha/windows_dsr
branch
from
34412f4 to
e321089
Compare
pjohnst5
reviewed
Nov 22, 2021
Contributor
pjohnst5
left a comment
pjohnst5
left a comment
There was a problem hiding this comment.
Seems good to me, and talked TM about it, passed singletenancy hnsv2 testing with containerd, also passed singletenancy aks-engine hnsv1 tests in our pipelines
ashvindeodhar
requested changes
Nov 22, 2021
lint fix
tamilmani1989
force-pushed
the
tamanoha/windows_dsr
branch
from
70c448f to
c40bf3a
Compare
ashvindeodhar
approved these changes
Nov 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
This PR adds DSR policy by default for AKS windows. This allows pod to reach itself by cluster service ip. It also depends on enabling kube proxy DSR.
Issue Fixed:
Requirements:
Notes: