fix: [CNS] fixing a regex to extract hostip in getncversion req #1140
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Due to wrong regex the hostip is extracted out wrong resulting in 400 badrequest from NMAgent
https://regex101.com/r/pkrHQv/1
azure-container-networking/cns/restserver/api.go
Line 1085 in 4a4370b
below is a log snippet, the host ip should be just the IP and not "168.63.129.16/machine/plugins/?comp=nmagent&type=NetworkManagement" regex is not parsing.
[Azure-CNS] Storing ncGetVersionURL for NC ID 53347415-65c7-47af-b13d-31ed8acd1272: HOST IP 168.63.129.16/machine/plugins/?comp=nmagent&type=NetworkManagement , join net url http://168.63.129.16/machine/plugins/?comp=nmagent&type=NetworkManagement/joinedVirtualNetworks/4941a21f-1a8d-4d0f-8256-cc6e73a8cd22/api-version/1, urlfmt, http://%s/machine/plugins/?comp=nmagent&type=NetworkManagement/interfaces/%s/networkContainers/%s/version/authenticationToken/%s/api-version/1 , ncGetVersionURL: http://168.63.129.16/machine/plugins/?comp=nmagent&type=NetworkManagement/machine/plugins/?comp=nmagent&type=NetworkManagement/interfaces/10.92.0.29/networkContainers/53347415-65c7-47af-b13d-31ed8acd1272/version/authenticationToken/7598a099-1292-480b-a1cd-3d6df5038578/api-version/1
Issue Fixed:
Requirements:
Notes: