appinsights zapcore #1158
Merged
appinsights zapcore #1158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbtr
requested review from
matmerr,
ramiro-gamarra,
thatmattlong and
vakalapa
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
Contributor
ramiro-gamarra
left a comment
ramiro-gamarra
left a comment
There was a problem hiding this comment.
Just some very minor things. Would be great to see a demo. It's a pleasure reviewing a PR like this.
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
ramiro-gamarra
approved these changes
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Evan Baker rbtr@users.noreply.github.com
Reason for Change:
Adds
zapaipackage containing an MVP working AppInsights implementation of a zap.Core.Because we need to improve our logging framework (and zap would be good for that) but things like CNS need to send logs via AI.
Issue Fixed:
Requirements:
Notes: