Skip to content

fix: [NPM] eliminate chance of ipset race between pod delete and netpol create #1257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2022
Merged

fix: [NPM] eliminate chance of ipset race between pod delete and netpol create #1257

merged 1 commit into from
Feb 25, 2022

Conversation

@huntergregory
Copy link
Contributor

@huntergregory huntergregory commented Feb 24, 2022

Lock ipsm while adding a netpol so that ipsets referenced by iptables rules can't be destroyed before the iptables rule are added.

@huntergregory huntergregory added the npm Related to NPM. label Feb 24, 2022
@huntergregory huntergregory mentioned this pull request Feb 24, 2022
Closed
@vakalapa vakalapa enabled auto-merge (squash) February 25, 2022 18:23
@rbtr rbtr disabled auto-merge February 25, 2022 18:26
@rbtr rbtr merged commit 5d8c2ae into master Feb 25, 2022
@rbtr rbtr deleted the hunter/fix-netpol-pod-race branch February 25, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vakalapa vakalapa vakalapa approved these changes

@matmerr matmerr Awaiting requested review from matmerr

Assignees

No one assigned

Labels

npm Related to NPM.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@huntergregory @vakalapa @rbtr