Skip to content

add hostname and version in the correct field in ai logs #1280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 16, 2022
Merged

add hostname and version in the correct field in ai logs #1280

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions aitelemetry/telemetrywrapper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package aitelemetry

import (
"fmt"
"os"
"runtime"
"time"

Expand All @@ -24,6 +25,7 @@ const (
vmIDStr = "VMID"
versionStr = "AppVersion"
azurePublicCloudStr = "AzurePublicCloud"
hostNameKey = "hostname"
defaultTimeout = 10
defaultBatchIntervalInSecs = 15
defaultBatchSizeInBytes = 32768
Expand Down Expand Up @@ -207,6 +209,8 @@ func (th *telemetryHandle) TrackLog(report Report) {
trace.Tags.User().SetAuthUserId(runtime.GOOS)
trace.Tags.Operation().SetId(report.Context)
trace.Tags.Operation().SetParentId(th.appVersion)
trace.Tags.Application().SetVer(th.appVersion)
Copy link
Member

@tamilmani1989 tamilmani1989 Mar 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some fields are not exported to kusto. did you check if this visible in kusto? in that case we can remove trace.Tags.Operation().SetParentId(th.appVersion)

trace.Properties[hostNameKey], _ = os.Hostname()

// copy app specified custom dimension
for key, value := range report.CustomDimensions {
Expand Down