Skip network creation if network already exists in HNS #1300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamilmani1989
requested changes
Apr 6, 2022
| return network.GetHCNObj(), nil | ||
| } | ||
| return &hcn.HostComputeNetwork{}, nil | ||
| return nil, hcn.NetworkNotFoundError{} |
Member
There was a problem hiding this comment.
just make sure cni code doesn't dereference pointer without checking for error
Contributor
Author
There was a problem hiding this comment.
this is the hns mock wrapper and only used by test code, no real cni code uses this type so there's no concerns.
| log.Printf("[net] Creating hcn network: %+v", hcnNetwork) | ||
| hnsResponse, err := hnsv2.CreateNetwork(hcnNetwork) | ||
| // check if network exists, only create the network does not exist | ||
| hnsResponse, err := hnsv2.GetNetworkByName(hcnNetwork.Name) |
Member
There was a problem hiding this comment.
can you also log if network exists
Contributor
Author
There was a problem hiding this comment.
sure, added it when err is empty
| return nil, fmt.Errorf("Failed to create hcn network: %s due to error: %v", hcnNetwork.Name, err) | ||
| } | ||
| // if network not found, create the HNS network. | ||
| if errors.As(err, &hcn.NetworkNotFoundError{}) { |
Member
There was a problem hiding this comment.
can you add ut for testing these cases?
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
aegal
changed the title
matmerr
pushed a commit
to matmerr/azure-container-networking
that referenced
this pull request
Jun 29, 2022
* skip network creation if network already exists * address comments * address feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Issue Fixed:
Requirements:
Notes: