fix: [NPM] updating NPM marks with a mask to not clash with kube-proxy #1313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huntergregory
previously approved these changes
Apr 6, 2022
huntergregory
approved these changes
Apr 11, 2022
matmerr
pushed a commit
to matmerr/azure-container-networking
that referenced
this pull request
Jun 29, 2022
Azure#1313) * fix: [NPM] updating NPM marks with a mask to not clash with kube-proxy * updating mark to single bit instead of 2 bits for 500 * not touching v1 and adjusting UTs for V2 * correcting an UT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
NPM Dataplane V2 uses 0x4000 as INgress drop mark. this is clashing with kube-proxy Masq mark for ExternalLB Service with policy as Cluster. This change will use a different work of the 32 bit markable section of packet.
Issue Fixed:
Requirements:
Notes: