Skip to content

test: added additional ingress tests #1316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 19, 2022
Merged

test: added additional ingress tests #1316

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
139df19
added additional tests
ck319 Apr 2, 2022
09c216d
fixed lint issue
ck319 Apr 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
104 changes: 102 additions & 2 deletions npm/pkg/controlplane/translation/translatePolicy_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1290,12 +1290,14 @@ func TestIngressPolicy(t *testing.T) {
tcp := v1.ProtocolTCP
targetPodMatchType := policies.EitherMatch
peerMatchType := policies.SrcMatch
emptyString := intstr.FromString("")
// TODO(jungukcho): add test cases with more complex rules
tests := []struct {
name string
targetSelector *metav1.LabelSelector
rules []networkingv1.NetworkPolicyIngressRule
npmNetPol *policies.NPMNetworkPolicy
wantErr bool
}{
{
name: "only port in ingress rules",
Expand Down Expand Up @@ -1557,6 +1559,100 @@ func TestIngressPolicy(t *testing.T) {
},
},
},
{
name: "error",
targetSelector: &metav1.LabelSelector{
MatchLabels: map[string]string{
"label": "src",
},
},
rules: []networkingv1.NetworkPolicyIngressRule{
{
Ports: []networkingv1.NetworkPolicyPort{
{
Protocol: &tcp,
Port: &emptyString,
},
},
},
},
npmNetPol: &policies.NPMNetworkPolicy{
Name: "serve-tcp",
NameSpace: "default",
PodSelectorIPSets: []*ipsets.TranslatedIPSet{
ipsets.NewTranslatedIPSet("label:src", ipsets.KeyValueLabelOfPod),
ipsets.NewTranslatedIPSet("default", ipsets.Namespace),
},
PodSelectorList: []policies.SetInfo{
policies.NewSetInfo("label:src", ipsets.KeyValueLabelOfPod, included, targetPodMatchType),
policies.NewSetInfo("default", ipsets.Namespace, included, targetPodMatchType),
},
ACLs: []*policies.ACLPolicy{
{
PolicyID: "azure-acl-default-serve-tcp",
Target: policies.Allowed,
Direction: policies.Ingress,
Protocol: "TCP",
},
defaultDropACL("default", "serve-tcp", policies.Ingress),
},
},
wantErr: true,
},
{
name: "allow all ingress rules",
targetSelector: &metav1.LabelSelector{
MatchLabels: map[string]string{
"label": "src",
},
},
rules: []networkingv1.NetworkPolicyIngressRule{
{},
},
npmNetPol: &policies.NPMNetworkPolicy{
Name: "serve-tcp",
NameSpace: "default",
PodSelectorIPSets: []*ipsets.TranslatedIPSet{
ipsets.NewTranslatedIPSet("label:src", ipsets.KeyValueLabelOfPod),
ipsets.NewTranslatedIPSet("default", ipsets.Namespace),
},
PodSelectorList: []policies.SetInfo{
policies.NewSetInfo("label:src", ipsets.KeyValueLabelOfPod, included, targetPodMatchType),
policies.NewSetInfo("default", ipsets.Namespace, included, targetPodMatchType),
},
ACLs: []*policies.ACLPolicy{
{
PolicyID: "azure-acl-default-serve-tcp",
Target: policies.Allowed,
Direction: policies.Ingress,
},
},
},
},
{
name: "deny all in ingress rules",
targetSelector: &metav1.LabelSelector{
MatchLabels: map[string]string{
"label": "src",
},
},
rules: nil,
npmNetPol: &policies.NPMNetworkPolicy{
Name: "serve-tcp",
NameSpace: "default",
PodSelectorIPSets: []*ipsets.TranslatedIPSet{
ipsets.NewTranslatedIPSet("label:src", ipsets.KeyValueLabelOfPod),
ipsets.NewTranslatedIPSet("default", ipsets.Namespace),
},
PodSelectorList: []policies.SetInfo{
policies.NewSetInfo("label:src", ipsets.KeyValueLabelOfPod, included, targetPodMatchType),
policies.NewSetInfo("default", ipsets.Namespace, included, targetPodMatchType),
},
ACLs: []*policies.ACLPolicy{
defaultDropACL("default", "serve-tcp", policies.Ingress),
},
},
},
}

for _, tt := range tests {
Expand All @@ -1571,8 +1667,12 @@ func TestIngressPolicy(t *testing.T) {
npmNetPol.PodSelectorIPSets, npmNetPol.PodSelectorList, err = podSelectorWithNS(npmNetPol.NameSpace, policies.EitherMatch, tt.targetSelector)
require.NoError(t, err)
err = ingressPolicy(npmNetPol, tt.rules)
require.NoError(t, err)
require.Equal(t, tt.npmNetPol, npmNetPol)
if tt.wantErr {
require.Error(t, err)
} else {
require.NoError(t, err)
require.Equal(t, tt.npmNetPol, npmNetPol)
}
})
}
}