move metrics to service port, add healthz, pprof #1318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulgmiller
reviewed
Apr 4, 2022
cns/service/main.go
Outdated
| mux.HandleFunc("/debug/pprof/trace", pprof.Trace) | ||
| } | ||
|
|
||
| // to reduce |
Member
There was a problem hiding this comment.
sadparital comment left behind by paul.
paulgmiller
previously approved these changes
Apr 4, 2022
| return errors.Wrapf(err, "failed to setup reconciler with manager") | ||
| } | ||
|
|
||
| mux := httpRestServiceImplementation.Listener.GetMux() |
Member
There was a problem hiding this comment.
we have to remember to update the metrics annotation port when we bring this in. Weee non atomic changes.
| mux.Handle("/metrics", promhttp.HandlerFor(metrics.Registry, promhttp.HandlerOpts{ | ||
| ErrorHandling: promhttp.HTTPErrorOnError, | ||
| })) | ||
| healthzhandler := healthz.Handler{} |
Member
There was a problem hiding this comment.
no idea if this little heathz framework from controller-runtime is good or not. Feel freee to toss.
rbtr
force-pushed
the
healthz
branch
3 times, most recently
from
bc1cc6e to
ab917ee
Compare
thatmattlong
previously approved these changes
Apr 4, 2022
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
thatmattlong
approved these changes
Apr 4, 2022
rbtr
added a commit
to rbtr/azure-container-networking
that referenced
this pull request
May 4, 2022
This reverts commit 5ec6a3f.
rbtr
added a commit
to rbtr/azure-container-networking
that referenced
this pull request
May 4, 2022
This reverts commit 5ec6a3f.
rbtr
added a commit
to rbtr/azure-container-networking
that referenced
this pull request
May 4, 2022
This reverts commit 5ec6a3f.
neaggarwMS
pushed a commit
that referenced
this pull request
May 5, 2022
rsagasthya
pushed a commit
to rsagasthya/azure-container-networking
that referenced
this pull request
May 18, 2022
Azure#1362) This reverts commit 5ec6a3f.
matmerr
pushed a commit
to matmerr/azure-container-networking
that referenced
this pull request
Jun 29, 2022
* combine metrics and healthz * use root mux and bind pprof routes on debug config opt Signed-off-by: Evan Baker <rbtr@users.noreply.github.com> Co-authored-by: Paul Miller <pmiller@microsoft.com>
matmerr
pushed a commit
to matmerr/azure-container-networking
that referenced
this pull request
Jun 29, 2022
Azure#1362) This reverts commit 5ec6a3f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
debugconfig opt.Issue Fixed:
Closes #1294 (because I can't push to it)
Requirements:
Notes: