Don't overwrite Spec in IPAM PoolMonitor from NNC again after initialization #1328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbtr
added
cns
rbtr
requested review from
neaggarwMS and
rsagasthya
and removed request for
a team
Member
Member
rbtr
changed the title
neaggarwMS
requested changes
Apr 13, 2022
cns/ipampool/monitor.go
Outdated
| } | ||
|
|
||
| func (pm *Monitor) reconcile(ctx context.Context) error { | ||
| pm.mu.Lock() // lock the monitor to prevent scaling races |
Member
There was a problem hiding this comment.
Move this to the caller before you read pm.Spec
| pm.metastate.minFreeCount, pm.metastate.maxFreeCount = CalculateMinFreeIPs(scaler), CalculateMaxFreeIPs(scaler) | ||
| pm.once.Do(func() { close(pm.started) }) // close the init channel the first time we receive a NodeNetworkConfig. | ||
| pm.once.Do(func() { | ||
| pm.spec = nnc.Spec // set the spec from the NNC initially (afterwards we write the Spec so we know target state). |
Member
There was a problem hiding this comment.
Also add a log line in func (pm *Monitor) Update(nnc *v1alpha.NodeNetworkConfig) error { function.
neaggarwMS
previously approved these changes
Apr 13, 2022
… NNC Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
neaggarwMS
approved these changes
Apr 14, 2022
matmerr
pushed a commit
to matmerr/azure-container-networking
that referenced
this pull request
Jun 29, 2022
… NNC (Azure#1328) Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Evan Baker rbtr@users.noreply.github.com
Reason for Change:
After init, the PoolMonitor writes the Spec, so it has the target state locally and should not let the NNC updates it receives overwrite that local state.
Issue Fixed:
Requirements:
Notes: