-
Notifications
You must be signed in to change notification settings - Fork 260
build multiplat manifests with buildah #1356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9c9d820 to
a255453
Compare
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
jaer-tsun
reviewed
May 4, 2022
| set -e | ||
| export PLATFORM_TAG=$(make container-platform-tag TAG=${{ parameters.tag }} PLATFORM=${{ parameters.os }}/${{ parameters.arch }}) | ||
| export REF=$(IMAGE_REGISTRY)/$(make ${{ parameters.name }}-image-name):$PLATFORM_TAG | ||
| skopeo copy containers-storage:$REF docker-daemon:$REF |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
jaer-tsun
approved these changes
May 4, 2022
Contributor
jaer-tsun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Collaborator
Author
|
patching together various runs, tests have passed |
rsagasthya
pushed a commit
to rsagasthya/azure-container-networking
that referenced
this pull request
May 18, 2022
* build multiplat manifests with buildah Signed-off-by: Evan Baker <rbtr@users.noreply.github.com> * copy container in to docker-daemon cache and re-enable trivvy Signed-off-by: Evan Baker <rbtr@users.noreply.github.com> * set -e Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
matmerr
pushed a commit
to matmerr/azure-container-networking
that referenced
this pull request
Jun 29, 2022
* build multiplat manifests with buildah Signed-off-by: Evan Baker <rbtr@users.noreply.github.com> * copy container in to docker-daemon cache and re-enable trivvy Signed-off-by: Evan Baker <rbtr@users.noreply.github.com> * set -e Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Evan Baker rbtr@users.noreply.github.com
Reason for Change:
Issue Fixed:
Requirements:
Notes: