fix: Service Account Mitigation for CNS on k8s Windows 2022 #1367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbtr
reviewed
May 6, 2022
Collaborator
|
what was the issue that this fixes? |
Contributor
Author
Hoping this will resolve those SA issues for host process containers e.g. |
jaer-tsun
force-pushed
the
cnsSAHack
branch
2 times, most recently
from
1049132 to
2ef976d
Compare
rbtr
requested changes
May 9, 2022
jaer-tsun
commented
May 10, 2022
rbtr
approved these changes
May 20, 2022
Collaborator
rbtr
left a comment
rbtr
left a comment
There was a problem hiding this comment.
it shouldn't be necessary to do this kubeconfig templating (should be easy to set all of these fields on the rest.Config directly since it's mostly the in-cluster config). but if it works for now until the windows support is better and we don't need it at all, okay
matmerr
pushed a commit
to matmerr/azure-container-networking
that referenced
this pull request
Jun 29, 2022
* Service Account Mitigation for CNS on k8s Windows 2022 * pick up Neha's bug fix * addressing comments * add node selector back Co-authored-by: Jaeryn <tsun.chu@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Service Account Mitigation for CNS on k8s Windows 2022
Issue Fixed:
Requirements:
Notes: