fix: [NPM] windows-specific controller race leads to policy doesn't exist error while policy is pending #1400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vakalapa
approved these changes
May 25, 2022
matmerr
pushed a commit
to matmerr/azure-container-networking
that referenced
this pull request
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any of the three controllers can call
dp.ApplyDataPlane()at any time, so we have to be careful of this situation:AddPolicyis calledApplyDataPlane()is called after the selector IPSets are created, but before the network policy is appliedWhen applying ipsets to the kernel in Windows, we need to add/remove policies from pod endpoints based on whether the pod now satisfies or no longer satisfies a policy's selector. This change makes sure we don't try to add a policy that is "pending" (about to be added to the kernel) in
dp.updatePod()Once the pending policy is applied, then existing code already applies the policy to all necessary endpoints.