-
Notifications
You must be signed in to change notification settings - Fork 260
Port DeleteNetworkContainer and SetOrchestratorType from DNC #1454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
timraymond
merged 10 commits into
Azure:master
from
timraymond:timraymond/port-cns-endpoints
Jul 11, 2022
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
ca3bdce
Add DeleteNetworkContainer method to CNS Client
timraymond 748d40d
Remove return value from DeleteNetworkContainer
timraymond d89be0c
Add SetOrchestratorType endpoint to cns client
timraymond ebdfd6b
Fix two linter issues
timraymond 52b4dcf
Add CreateNetworkContainer endpoint to client
timraymond 49cb2eb
Add a PublishNetworkContainer to CNS client
timraymond 3492f54
Fix placeholder error message
timraymond 9c68785
Add context to DeleteNetworkContainer
timraymond 48c4646
Fix PublishNetworkContainer return type
timraymond ff4a03a
Add UnpublishNC to CNS Client
timraymond File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would a client want to handle errors differently for different error codes? I see other methods doing something similar but if we are going to start consuming this from DNC, I would like to leave this as open for future compatibility and return the actual API contract struct. Probably create new methods for all the methods that we will use from DNC.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is likely that a client would want to handle errors differently (notably retries for temporary errors). I still think the better way to do it is by having a
TemporaryErrorlike I did in the NMAgent client (this is the same idea as Dave Cheney's "don't just check errors, handle them gracefully").I like this because the knowledge about what constitutes a temporary error (i.e. what do the error codes mean) is in exactly one place: the
IsTemporary()method (or equivalent for other classes of error).