Fixed the #108 issue. #154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamilmani1989
requested changes
May 31, 2018
| osInfoArr := make(map[string]string) | ||
|
|
||
| for i := range linesArr { | ||
| s := strings.Split(linesArr[i], "=") |
Member
There was a problem hiding this comment.
can we check if split succeeds by checking the length of s?
Contributor
Author
There was a problem hiding this comment.
Please check if the latest commit is what you want.
tamilmani1989
requested changes
Jun 1, 2018
tamilmani1989
requested changes
Jun 4, 2018
telemetry/telemetry_linux.go
Outdated
|
|
||
| for i := range linesArr { | ||
| s := strings.Split(linesArr[i], "=") | ||
| if len(s) = 2 { |
Member
There was a problem hiding this comment.
shouldn't it be len(s)==2?
IvanovOleg
commented
Jun 4, 2018
Contributor
Author
IvanovOleg
left a comment
IvanovOleg
left a comment
There was a problem hiding this comment.
Fixed the typo
telemetry/telemetry_linux.go
Outdated
|
|
||
| for i := range linesArr { | ||
| s := strings.Split(linesArr[i], "=") | ||
| if len(s) = 2 { |
tamilmani1989
approved these changes
Jun 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Use /etc/os-release instead of /etc/issue as a source for the osInfo because /etc/issue contains completely different lines depending on the linux distributive and fails on the CoreOS.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #108Special notes for your reviewer:
Split PRs as required
Release note: