run Windows UT's #1554
Merged
run Windows UT's #1554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
huntergregory
force-pushed
the
windowsuts
branch
from
2329f2f to
57913b9
Compare
huntergregory
requested review from
huntergregory
and removed request for
a team
huntergregory
force-pushed
the
windowsuts
branch
from
762e20e to
feea2ae
Compare
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
…rking into windowsuts
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
timraymond
reviewed
Oct 17, 2022
common/ioshim_windows.go
Outdated
|
|
||
| _, err := hns.CreateNetwork(network) | ||
| if err != nil { | ||
| return nil |
Member
There was a problem hiding this comment.
I know it's a mock, but it still might be nice to put a comment saying why we're tossing the error here. There's a knee-jerk reaction to return all errors, so this seems odd from an eye-glance.
Contributor
There was a problem hiding this comment.
At the least will need a log here.
Contributor
There was a problem hiding this comment.
added comments, since the network call never returns an error we decided to remove that check
| go test ./... | ||
| retryCountOnTaskFailure: 3 | ||
| name: "TestWindows" | ||
| displayName: "Run Windows Tests" |
Contributor
There was a problem hiding this comment.
TODO: run make test-all-windows
Contributor
There was a problem hiding this comment.
discussed to leave as is for now (also don't want to run non-npm tests)
Contributor
There was a problem hiding this comment.
also need special treatment for windows (no make installed)
vakalapa
approved these changes
Oct 20, 2022
rjdenney
pushed a commit
to rjdenney/azure-container-networking
that referenced
this pull request
Jan 19, 2023
* run windows UT's * container image * remove container * coverage * run windows UT's * container image * remove container * coverage * fix UTs round 1 * passing UTs for policies pkg * use canary pool * remove bash from windows * fixed unit test * added skip for windows dp translate policy tests * lint updates and remove dataplane_windows_test.go * updated failing tests * fix lint issue * fixed remaining tests * lint update * undo last change * format update * lint fix Co-authored-by: Hunter Gregory <hunterlgregory@gmail.com> Co-authored-by: Vamsi Kalapala <vakr@microsoft.com> Co-authored-by: CK <ckov931@gmail.com> Co-authored-by: Cristina Kovacs <99916704+ck319@users.noreply.github.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Issue Fixed:
Requirements:
Notes: