Skip to content

Pipelines: Failfast on an error #1592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 9, 2022
Merged

Pipelines: Failfast on an error #1592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a44f84e
fix: pipelines exit early on error
vakalapa Sep 9, 2022
4d420be
fix: pipelines exit early on error
vakalapa Sep 9, 2022
6aae312
adding fail check
vakalapa Sep 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions .pipelines/npm/npm-conformance-tests-latest-release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,12 @@ jobs:
--node-vm-size Standard_D4s_v3 \
--node-count 1

if [ $? != 0 ]
then
echo "Failing fast since previous command failed"
exit 1
fi

# don't schedule anything on the linux system pool
echo "Updating $(AZURE_CLUSTER) to not schedule anything on linux pool..."
az aks nodepool update \
Expand All @@ -149,6 +155,12 @@ jobs:
-n nodepool1 \
--node-taints CriticalAddonsOnly=true:NoSchedule

if [ $? != 0 ]
then
echo "Failing fast since previous command failed"
exit 1
fi

echo "Adding Windows nodepool to $(AZURE_CLUSTER) to group $(RESOURCE_GROUP)"
az aks nodepool add \
--resource-group $(RESOURCE_GROUP) \
Expand All @@ -159,6 +171,12 @@ jobs:
--node-vm-size Standard_D4s_v3 \
--node-count 2

if [ $? != 0 ]
then
echo "Failing fast since previous command failed"
exit 1
fi

az aks get-credentials -n $(AZURE_CLUSTER) -g $(RESOURCE_GROUP) --file ./kubeconfig
./kubectl --kubeconfig=./kubeconfig apply -f https://raw.githubusercontent.com/Azure/azure-container-networking/master/npm/examples/windows/azure-npm.yaml
./kubectl --kubeconfig=./kubeconfig set image daemonset/azure-npm-win -n kube-system azure-npm=$IMAGE_REGISTRY/azure-npm:windows-amd64-$(TAG)
Expand All @@ -170,6 +188,12 @@ jobs:
--name $(AZURE_CLUSTER) \
--network-plugin azure

if [ $? != 0 ]
then
echo "Failing fast since previous command failed"
exit 1
fi

az aks get-credentials -n $(AZURE_CLUSTER) -g $(RESOURCE_GROUP) --file ./kubeconfig

# deploy azure-npm
Expand All @@ -185,6 +209,12 @@ jobs:

./kubectl --kubeconfig=./kubeconfig describe daemonset azure-npm -n kube-system

if [ $? != 0 ]
then
echo "Failing fast since previous command failed"
exit 1
fi

FQDN=`az aks show -n $(AZURE_CLUSTER) -g $(RESOURCE_GROUP) --query fqdn -o tsv`
echo "##vso[task.setvariable variable=FQDN]$FQDN"
- bash: |
Expand Down
33 changes: 30 additions & 3 deletions .pipelines/npm/npm-conformance-tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,12 @@ jobs:
--node-vm-size Standard_D4s_v3 \
--node-count 1

if [ $? != 0 ]
then
echo "Failing fast since previous command failed"
exit 1
fi

# don't schedule anything on the linux system pool
echo "Updating $(AZURE_CLUSTER) to not schedule anything on linux pool..."
az aks nodepool update \
Expand All @@ -194,6 +200,12 @@ jobs:
-n nodepool1 \
--node-taints CriticalAddonsOnly=true:NoSchedule

if [ $? != 0 ]
then
echo "Failing fast since previous command failed"
exit 1
fi

echo "Adding Windows nodepool to $(AZURE_CLUSTER) to group $(RESOURCE_GROUP)"
az aks nodepool add \
--resource-group $(RESOURCE_GROUP) \
Expand All @@ -204,6 +216,12 @@ jobs:
--node-vm-size Standard_D4s_v3 \
--node-count 2

if [ $? != 0 ]
then
echo "Failing fast since previous command failed"
exit 1
fi

az aks get-credentials -n $(AZURE_CLUSTER) -g $(RESOURCE_GROUP) --file ./kubeconfig
./kubectl --kubeconfig=./kubeconfig apply -f https://raw.githubusercontent.com/Azure/azure-container-networking/master/npm/examples/windows/azure-npm.yaml
./kubectl --kubeconfig=./kubeconfig set image daemonset/azure-npm-win -n kube-system azure-npm=$IMAGE_REGISTRY/azure-npm:windows-amd64-$(TAG)
Expand All @@ -215,6 +233,12 @@ jobs:
--name $(AZURE_CLUSTER) \
--network-plugin azure

if [ $? != 0 ]
then
echo "Failing fast since previous command failed"
exit 1
fi

az aks get-credentials -n $(AZURE_CLUSTER) -g $(RESOURCE_GROUP) --file ./kubeconfig

# deploy azure-npm
Expand All @@ -230,6 +254,12 @@ jobs:

./kubectl --kubeconfig=./kubeconfig describe daemonset azure-npm -n kube-system

if [ $? != 0 ]
then
echo "Failing fast since previous command failed"
exit 1
fi

FQDN=`az aks show -n $(AZURE_CLUSTER) -g $(RESOURCE_GROUP) --query fqdn -o tsv`
echo "##vso[task.setvariable variable=FQDN]$FQDN"
- bash: |
Expand Down Expand Up @@ -439,8 +469,6 @@ jobs:
FQDN=`az aks show -n $CLUSTER_NAME -g $CLUSTER_NAME --query fqdn -o tsv`
echo "##vso[task.setvariable variable=FQDN]$FQDN"



- script: |
cat ~/.kube/config
curl -fsSL github.com/mattfenwick/cyclonus/releases/latest/download/cyclonus_linux_amd64.tar.gz | tar -zxv
Expand All @@ -449,7 +477,6 @@ jobs:
failOnStderr: false
condition: always()


- script: |
./test/cyclonus/test-cyclonus-windows.sh
name: cyclonus
Expand Down