Update test cns daemonset to reconcile its own state #1622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamilmani1989
requested changes
Sep 16, 2022
tamilmani1989
previously approved these changes
Sep 16, 2022
rbtr
requested changes
Sep 16, 2022
Collaborator
rbtr
left a comment
rbtr
left a comment
There was a problem hiding this comment.
we still need coverage of the reconcile-from-CNI scenario, I don't think we can update this for all swift E2Es
Contributor
Author
If I use different configmaps for cilium and swift, would that keep coverage for reconciling from cni? |
rbtr
approved these changes
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
enabling ManageEndpointState in configmap and updating cns daemonset in e2e tests so that cns will reconcile its own state
Issue Fixed:
Requirements:
Notes: