remove akse linux and pass ossku to cluster create #1658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbtr
reviewed
Oct 18, 2022
Collaborator
rbtr
left a comment
rbtr
left a comment
There was a problem hiding this comment.
looks good to me pending a couple of questions
hack/swift/Makefile
Outdated
| --vnet-subnet-id /subscriptions/$(SUB)/resourceGroups/$(GROUP)/providers/Microsoft.Network/virtualNetworks/$(VNET)/subnets/nodenet \ | ||
| --pod-subnet-id /subscriptions/$(SUB)/resourceGroups/$(GROUP)/providers/Microsoft.Network/virtualNetworks/$(VNET)/subnets/podnet \ | ||
| --generate-ssh-keys \ | ||
| --os-sku $(OSSKU) |
Collaborator
There was a problem hiding this comment.
what happens if we don't specify this? jw because I thought that Ubuntu was the default.
Contributor
Author
There was a problem hiding this comment.
It does default to Ubuntu, just passing this parameter to setup the next P.R where I will create it with OS sku of windows. The windows part of it has a little more around it so thought it’s best to separate the P.R’s
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s), but failed to run 1 pipeline(s). |
rbtr
approved these changes
Oct 18, 2022
estebancams
previously approved these changes
Oct 19, 2022
rbtr
force-pushed
the
alegal/passosku_replaceubuntuakse
branch
from
4bd0f75 to
7f55ca9
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s), but failed to run 1 pipeline(s). |
Collaborator
|
@aegal looks like you've got some syntax errors: https://msazure.visualstudio.com/One/_build/results?buildId=62359894&view=results |
rbtr
requested changes
Oct 19, 2022
Co-authored-by: Evan Baker <rbtr@users.noreply.github.com>
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
correct typo
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
rbtr
approved these changes
Oct 25, 2022
rjdenney
pushed a commit
to rjdenney/azure-container-networking
that referenced
this pull request
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Issue Fixed:
Requirements:
Notes: