Migrate powershell docker scripts to docker@2 #1666
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estebancams
changed the title
estebancams
force-pushed
the
estebanca/update-windows-template-native-docker
branch
from
000d55a to
3f77000
Compare
estebancams
force-pushed
the
estebanca/update-windows-template-native-docker
branch
3 times, most recently
from
a01856f to
194e6aa
Compare
estebancams
changed the title
camrynl
requested changes
Nov 1, 2022
| tags: 'windows-${{ parameters.arch }}-${{ parameters.tag }}' | ||
| Dockerfile: '${{ parameters.name }}/windows.Dockerfile' | ||
| arguments: ' | ||
| --build-arg VERSION=windows-${{ parameters.arch }}-${{ parameters.tag }} |
Contributor
There was a problem hiding this comment.
it looks like --build-arg is causing some errors in npm conformance test windows image builds
Contributor
Author
There was a problem hiding this comment.
Thanks, fixed this issue
camrynl
previously approved these changes
Nov 3, 2022
camrynl
previously approved these changes
Nov 3, 2022
rbtr
previously approved these changes
Nov 3, 2022
rbtr
force-pushed
the
estebanca/update-windows-template-native-docker
branch
from
12f7f01 to
19d8a65
Compare
estebancams
force-pushed
the
estebanca/update-windows-template-native-docker
branch
from
19d8a65 to
645a1b2
Compare
rbtr
previously approved these changes
Nov 4, 2022
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
estebancams
force-pushed
the
estebanca/update-windows-template-native-docker
branch
from
645a1b2 to
d03506c
Compare
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
rbtr
approved these changes
Nov 17, 2022
rjdenney
pushed a commit
to rjdenney/azure-container-networking
that referenced
this pull request
Jan 19, 2023
* feat: migrate powershell docker scripts to docker@2 * feat: added retry to docker task * fix: added repo info for image push step * fix: added missing parameters for windows template parents * fix: removed debugging lines Co-authored-by: Esteban Capillo <estebancams@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
We are having intermittent failures when running docker powershell script in windows. Migrating to docker@2 is an attempt to fix this.
Even if this does not resolve the issue, still migrating to a native task is an improvement for pipelines
Issue Fixed:
Requirements:
Notes: