Skip to content

fix: hide echo banner in log #1669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 16, 2022
Merged

fix: hide echo banner in log #1669

merged 1 commit into from
Nov 16, 2022

Conversation

@rbtr
Copy link
Collaborator

@rbtr rbtr commented Oct 20, 2022

Signed-off-by: Evan Baker rbtr@users.noreply.github.com

Reason for Change:

hide this:

...

   ____    __
  / __/___/ /  ___
 / _// __/ _ \/ _ \
/___/\__/_//_/\___/ v4.7.2
High performance, minimalist Go web framework
https://echo.labstack.com
____________________________________O/_______
                                    O\
⇨ http server started on [::]:10092
...

from the CNS logs

Issue Fixed:

Requirements:

Notes:

@rbtr rbtr requested a review from a team as a code owner October 20, 2022 23:45
@rbtr rbtr requested review from thatmattlong and removed request for a team October 20, 2022 23:45
@rbtr rbtr self-assigned this Oct 20, 2022
@rbtr rbtr added cns Related to CNS. fix Fixes something. labels Oct 20, 2022
ramiro-gamarra
ramiro-gamarra previously approved these changes Oct 21, 2022
View reviewed changes
@rbtr rbtr enabled auto-merge (squash) October 21, 2022 20:58
@rbtr rbtr force-pushed the echo-hidebanner branch 2 times, most recently from 0251ec9 to 357bf9d Compare November 2, 2022 20:50
camrynl
camrynl previously approved these changes Nov 4, 2022
View reviewed changes
@rbtr
fix: hide echo banner in log
40e9ca2 
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
@rbtr rbtr merged commit 3a5c72b into Azure:master Nov 16, 2022
@rbtr rbtr deleted the echo-hidebanner branch November 16, 2022 23:13
rjdenney pushed a commit to rjdenney/azure-container-networking that referenced this pull request Jan 19, 2023
@rbtr @rjdenney
fix: hide echo banner in log (Azure#1669)
5d0e7a6 
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>

Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timraymond timraymond timraymond approved these changes

@camrynl camrynl camrynl left review comments

@ramiro-gamarra ramiro-gamarra ramiro-gamarra left review comments

@thatmattlong thatmattlong Awaiting requested review from thatmattlong thatmattlong is a code owner automatically assigned from Azure/acn-cns-reviewers

Assignees

@rbtr rbtr

Labels

cns Related to CNS. fix Fixes something.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rbtr @timraymond @camrynl @ramiro-gamarra