Skip to content

test: [NPM] fail cyclonus if unfinished #1681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 31, 2022
Merged

test: [NPM] fail cyclonus if unfinished #1681

merged 5 commits into from
Oct 31, 2022

Conversation

@huntergregory
Copy link
Contributor

@huntergregory huntergregory commented Oct 26, 2022 •
edited
Loading

Previously, a timed-out cyclonus run may be considered green.

Additionally, this PR:

  • prints NPM pod state (e.g. restart count) and captures any previous pod logs
  • prevents chance of collisions for test resource groups names

@huntergregory huntergregory added npm Related to NPM. ci Infra or tooling. labels Oct 26, 2022
@huntergregory huntergregory force-pushed the hgregory/cyc-failure-detection branch from 359d130 to f766ccb Compare October 26, 2022 23:14
@huntergregory huntergregory enabled auto-merge (squash) October 28, 2022 00:38
@vakalapa vakalapa disabled auto-merge October 31, 2022 16:22
@vakalapa vakalapa merged commit 4d2331d into master Oct 31, 2022
@vakalapa vakalapa deleted the hgregory/cyc-failure-detection branch October 31, 2022 18:00
rjdenney pushed a commit to rjdenney/azure-container-networking that referenced this pull request Jan 19, 2023
@huntergregory @rjdenney
test: [NPM] fail cyclonus if unfinished (Azure#1681)
a612ab0 
* prevent chance of overlap in resource groups

* print npm pod state and capture previous logs

* fail cyclonus if it doesn't complete

* redirect to /dev/null

* remove incorrect use of --kubeconfig
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matmerr matmerr matmerr approved these changes

@ck319 ck319 Awaiting requested review from ck319

Assignees

No one assigned

Labels

ci Infra or tooling. npm Related to NPM.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@huntergregory @matmerr @vakalapa