fix: [NPM] add check for invalid /0 cidr #1739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
huntergregory
left a comment
huntergregory
left a comment
There was a problem hiding this comment.
added a comment about the UT. Could you also add a short description of the current issue and how your PR fixes it?
| ipblock: "2345:0425:2CA1:0000:0000:0567:5673:23b5 nomatch", | ||
| want: false, | ||
| }, | ||
| { |
Contributor
There was a problem hiding this comment.
not sure if there's a test for valid /0 yet
huntergregory
approved these changes
Jan 5, 2023
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
auto-merge was automatically disabled
February 8, 2023 17:34
Merge queue setting changed
vakalapa
approved these changes
Feb 24, 2023
rjdenney
pushed a commit
that referenced
this pull request
Mar 13, 2023
* add check for invalid /0 cidr * added UT for valid cidr --------- Co-authored-by: Hunter Gregory <42728408+huntergregory@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
This fixes an issue where we were not throwing an error for CIDRs whose IPs were not 0.0.0.0 and ended with /0 during translation. Any CIDR with [ip]/0 is invalid unless IP is 0.0.0.0.
Issue Fixed:
Requirements:
Notes:
Add check for invalid /0 CIDRs