-
Notifications
You must be signed in to change notification settings - Fork 260
fix: [NPM] add check for invalid /0 cidr #1739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
4ae7d0f
add check for invalid /0 cidr
ck319 e5cdc15
added UT for valid cidr
ck319 0c07cb9
Merge branch 'master' into ckovacs_invalidcidr
huntergregory a0f544c
Merge branch 'master' into ckovacs_invalidcidr
ck319 68a06d8
Merge branch 'master' into ckovacs_invalidcidr
ck319 53eb5c6
Merge branch 'master' into ckovacs_invalidcidr
ck319 e544b13
Merge branch 'master' into ckovacs_invalidcidr
ck319 e556b31
Merge branch 'master' into ckovacs_invalidcidr
ck319 913e5d3
Merge branch 'master' into ckovacs_invalidcidr
ck319 f360b63
Merge branch 'master' into ckovacs_invalidcidr
ck319 d0ea299
Merge branch 'master' into ckovacs_invalidcidr
ck319 5b0a25b
Merge branch 'master' into ckovacs_invalidcidr
ck319 1771b8e
Merge branch 'master' into ckovacs_invalidcidr
ck319 c337c0a
Merge branch 'master' into ckovacs_invalidcidr
ck319 cd9b948
Merge branch 'master' into ckovacs_invalidcidr
ck319 5864a2e
Merge branch 'master' into ckovacs_invalidcidr
ck319 c3e2fcf
Merge branch 'master' into ckovacs_invalidcidr
ck319 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if there's a test for valid /0 yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated