Skip to content

perf: [NPM-WIN] only track updatepods on-node #1743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 19, 2023
Merged

perf: [NPM-WIN] only track updatepods on-node #1743

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7aac625
only track updatepods on-node
huntergregory Jan 5, 2023
3104a84
Merge branch 'master' into hgregory/tracking-updatepods
huntergregory Jan 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions npm/pkg/dataplane/dataplane.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,8 @@ func (dp *DataPlane) AddToSets(setNames []*ipsets.IPSetMetadata, podMetadata *Po
if err != nil {
return fmt.Errorf("[DataPlane] error while adding to set: %w", err)
}
if dp.shouldUpdatePod() {

if dp.shouldUpdatePod() && podMetadata.NodeName == dp.nodeName {
klog.Infof("[DataPlane] Updating Sets to Add for pod key %s", podMetadata.PodKey)

// lock updatePodCache while reading/modifying or setting the updatePod in the cache
Expand Down Expand Up @@ -162,7 +163,7 @@ func (dp *DataPlane) RemoveFromSets(setNames []*ipsets.IPSetMetadata, podMetadat
return fmt.Errorf("[DataPlane] error while removing from set: %w", err)
}

if dp.shouldUpdatePod() {
if dp.shouldUpdatePod() && podMetadata.NodeName == dp.nodeName {
klog.Infof("[DataPlane] Updating Sets to Remove for pod key %s", podMetadata.PodKey)

// lock updatePodCache while reading/modifying or setting the updatePod in the cache
Expand Down Expand Up @@ -213,6 +214,7 @@ func (dp *DataPlane) ApplyDataPlane() error {
return fmt.Errorf("[DataPlane] error while applying IPSets: %w", err)
}

// NOTE: ideally we won't refresh Pod Endpoints if the updatePodCache is empty
if dp.shouldUpdatePod() {
err := dp.refreshPodEndpoints()
if err != nil {
Expand Down