Skip to content

fix: [WIN-NPM] revert breaking change to .exe filename #1843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 9, 2023
Merged

fix: [WIN-NPM] revert breaking change to .exe filename #1843

merged 1 commit into from
Mar 9, 2023

Conversation

@huntergregory
Copy link
Contributor

@huntergregory huntergregory commented Mar 8, 2023

Revert .exe change from:

  1. Add multiplat Windows 2019 and 2022 image support to tooling and pipelines, use for CNS/NPM #1820
  2. fix: [WIN-NPM] change .exe name and set PATH for containerd issue #1838

These changes would break production DaemonSets since the DaemonSet change rolls out async with the image upgrade.

@huntergregory huntergregory added npm Related to NPM. windows labels Mar 8, 2023
@huntergregory huntergregory requested a review from a team as a code owner March 8, 2023 21:50
@huntergregory huntergregory requested review from ck319 and removed request for a team March 8, 2023 21:50
@vakalapa vakalapa merged commit f0440f3 into master Mar 9, 2023
@vakalapa vakalapa deleted the hgregory/npm-ds-and-dockerfile branch March 9, 2023 00:44
rjdenney pushed a commit that referenced this pull request Mar 13, 2023
@huntergregory @rjdenney
fix: [WIN-NPM] revert breaking change to .exe filename (#1843)
dd86207 
revert .exe filename
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ck319 ck319 Awaiting requested review from ck319 ck319 is a code owner automatically assigned from Azure/acn-npm-reviewers

Assignees

No one assigned

Labels

npm Related to NPM. windows

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@huntergregory @vakalapa