Skip to content

fix: [WIN-NPM] revert breaking change to .exe filename #1843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2023
Merged

fix: [WIN-NPM] revert breaking change to .exe filename #1843

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions npm/examples/windows/azure-npm.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,14 +83,14 @@ spec:
hostNetwork: true
containers:
- name: azure-npm
image: mcr.microsoft.com/containernetworking/azure-npm:v1.4.29
image: mcr.microsoft.com/containernetworking/azure-npm:v1.4.45
command: ["powershell.exe"]
args:
[
'.\setkubeconfigpath.ps1',
";",
"powershell.exe",
'.\azure-npm.exe',
'.\npm.exe',
"start",
'--kubeconfig=.\kubeconfig',
]
Expand Down
4 changes: 2 additions & 2 deletions npm/windows.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,5 @@ FROM mcr.microsoft.com/windows/servercore:${OS_VERSION}
COPY --from=builder /usr/local/src/npm/examples/windows/kubeconfigtemplate.yaml kubeconfigtemplate.yaml
COPY --from=builder /usr/local/src/npm/examples/windows/setkubeconfigpath.ps1 setkubeconfigpath.ps1
COPY --from=builder /usr/local/src/npm/examples/windows/setkubeconfigpath-capz.ps1 setkubeconfigpath-capz.ps1
COPY --from=builder /usr/local/bin/azure-npm.exe azure-npm.exe
CMD ["azure-npm.exe", "start" "--kubeconfig=.\\kubeconfig"]
COPY --from=builder /usr/local/bin/azure-npm.exe npm.exe
CMD ["npm.exe", "start" "--kubeconfig=.\\kubeconfig"]