Skip to content

Conversation

@jpayne3506
Copy link
Contributor

Reason for Change:

To continue using make test-validate-state we need to parameterize the cni type. Adding CNI_TYPE enables us to use this for more then the default cilium, but also cniv1 and cniv2.

Issue Fixed:

Requirements:

Notes:
CNI_TYPE defaults to cilium, which matches the test/integration/load/load_test.go default for its -cni flag.
A majority of the uses of make test-validate-state are cilium focused and will not be affected by this change as the default remains the same.

@jpayne3506 jpayne3506 added the ci Infra or tooling. label Aug 8, 2023
@jpayne3506 jpayne3506 requested a review from a team as a code owner August 8, 2023 05:53
@jpayne3506 jpayne3506 self-assigned this Aug 8, 2023
@vipul-21 vipul-21 enabled auto-merge (squash) August 8, 2023 17:38
@vipul-21 vipul-21 merged commit 14b916b into Azure:master Aug 8, 2023
@jpayne3506 jpayne3506 deleted the jpayne3506/validateupdate branch August 8, 2023 18:28
@jpayne3506 jpayne3506 changed the title ci: Paramterize test-validate-state ci: Parameterize test-validate-state Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Infra or tooling.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants