New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIFO order for network policies #258

Merged
merged 2 commits into from Oct 12, 2018

Conversation

Projects
None yet
2 participants
@saiyan86
Member

saiyan86 commented Oct 11, 2018

What this PR does / why we need it:

This PR:

  1. Changes the order of Azure-NPM for applying network policies from FIFO to LIFO.
    As per @neumanndaniel suggested, kubernetes administrators/network operators usually apply a deny-all policy then whitelist certain traffic. Without this PR to achieve this, one would have to whitelist all traffic first then apply the deny-all policy.

  2. Adds Azure-NPM to CircleCI config for CI/CD.

Which issue this PR fixes:
Fixes #217

Special notes for your reviewer:
This is a change of behavior, not a bug fix.

saiyan86 added some commits Oct 11, 2018

@tamilmani1989

lgtm

@saiyan86 saiyan86 merged commit 434ddf7 into Azure:master Oct 12, 2018

1 check passed

license/cla All CLA requirements met.
Details

sharmasushant added a commit to sharmasushant/azure-container-networking that referenced this pull request Oct 24, 2018

LIFO order for network policies (Azure#258)
* reverseOrder

* add npm to circleCI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment