Add support in CNS to perform CNI Update #296

ninzavivek · 2019-01-30T18:57:35Z

No description provided.

codecov · 2019-01-30T18:59:58Z

Codecov Report

Merging #296 into master will increase coverage by 1.03%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #296      +/-   ##
=========================================
+ Coverage   45.16%   46.2%   +1.03%     
=========================================
  Files          25      25              
  Lines        3538    3424     -114     
=========================================
- Hits         1598    1582      -16     
+ Misses       1685    1601      -84     
+ Partials      255     241      -14

Impacted Files	Coverage Δ
telemetry/telemetrybuffer_linux.go	`62.5% <0%> (-25%)`	⬇️
telemetry/telemetry.go	`27.16% <0%> (-2.26%)`	⬇️
telemetry/telemetrybuffer.go	`49.78% <0%> (-2.21%)`	⬇️
telemetry/cnstelemetry.go	`0% <0%> (ø)`	⬆️
npm/iptm/iptm.go	`56.33% <0%> (+1.45%)`	⬆️
npm/namespace.go	`65.09% <0%> (+6.44%)`	⬆️
npm/pod.go	`68.68% <0%> (+6.83%)`	⬆️
npm/npm.go	`10.28% <0%> (+8.39%)`	⬆️
npm/nwpolicy.go	`63.41% <0%> (+8.41%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a59572...255aae4. Read the comment docs.

cns/networkcontainers/networkcontainers_linux.go

cns/restserver/restserver.go

cns/networkcontainers/networkcontainers_linux.go

cns/networkcontainers/networkcontainers_windows.go

cns/restserver/restserver.go

cns/networkcontainers/networkcontainers.go

cns/networkcontainers/networkcontainers_linux.go

cns/restserver/restserver.go

cns/networkcontainers/networkcontainers.go

cns/networkcontainers/networkcontainers_linux.go

cns/restserver/restserver.go

cns/networkcontainers/networkcontainers_linux.go

cns/restserver/restserver.go

network/endpoint.go

jaer-tsun · 2019-03-11T17:18:56Z

network/endpoint_test.go

+
+func TestGetPodName(t *testing.T) {
+	testData := map[string]string{
+		"nginx-deployment-5c689d88bb":       "nginx",


Can you gofmt this? It's just spacing/formatting. Unsure if it looks like this because of GitHub

jaer-tsun · 2019-03-11T17:21:12Z

network/endpoint_test.go

+
+	for testValue, expectedPodName := range testData {
+		podName := GetPodNameWithoutSuffix(testValue)
+


remove space

jaer-tsun

lgtm, other than some white space/formatting stuff

Sushant is OOF.

jaer-tsun

lgtm

ninzavivek requested review from sharmasushant and tamilmani1989 January 30, 2019 18:57

sharmasushant requested a review from jaer-tsun January 30, 2019 18:59

sharmasushant changed the title ~~CNI Update operation support~~ Add support in CNS to perform CNI Update Jan 30, 2019

jaer-tsun reviewed Jan 30, 2019

View reviewed changes

cns/networkcontainers/networkcontainers_linux.go Outdated Show resolved Hide resolved

ninzavivek commented Jan 30, 2019

View reviewed changes

cns/restserver/restserver.go Show resolved Hide resolved

ninzavivek commented Jan 30, 2019

View reviewed changes

cns/networkcontainers/networkcontainers_linux.go Outdated Show resolved Hide resolved

ninzavivek commented Jan 30, 2019

View reviewed changes

cns/networkcontainers/networkcontainers_linux.go Outdated Show resolved Hide resolved

jaer-tsun reviewed Jan 30, 2019

View reviewed changes

cns/networkcontainers/networkcontainers_linux.go Outdated Show resolved Hide resolved

jaer-tsun reviewed Jan 30, 2019

View reviewed changes

cns/networkcontainers/networkcontainers_linux.go Outdated Show resolved Hide resolved

jaer-tsun reviewed Jan 30, 2019

View reviewed changes

cns/networkcontainers/networkcontainers_linux.go Show resolved Hide resolved

tamilmani1989 reviewed Jan 30, 2019

View reviewed changes

cns/networkcontainers/networkcontainers_linux.go Outdated Show resolved Hide resolved

jaer-tsun reviewed Jan 30, 2019

View reviewed changes

cns/networkcontainers/networkcontainers_linux.go Outdated Show resolved Hide resolved

jaer-tsun reviewed Jan 30, 2019

View reviewed changes

cns/networkcontainers/networkcontainers_linux.go Outdated Show resolved Hide resolved

jaer-tsun reviewed Jan 30, 2019

View reviewed changes

cns/networkcontainers/networkcontainers_linux.go Outdated Show resolved Hide resolved

jaer-tsun reviewed Jan 30, 2019

View reviewed changes

cns/networkcontainers/networkcontainers_linux.go Outdated Show resolved Hide resolved

jaer-tsun reviewed Jan 30, 2019

View reviewed changes

cns/networkcontainers/networkcontainers_linux.go Outdated Show resolved Hide resolved

jaer-tsun reviewed Jan 30, 2019

View reviewed changes

cns/networkcontainers/networkcontainers_windows.go Show resolved Hide resolved

jaer-tsun reviewed Jan 30, 2019

View reviewed changes

cns/restserver/restserver.go Outdated Show resolved Hide resolved

jaer-tsun reviewed Jan 30, 2019

View reviewed changes

cns/restserver/restserver.go Outdated Show resolved Hide resolved

jaer-tsun reviewed Feb 4, 2019

View reviewed changes

cns/networkcontainers/networkcontainers.go Outdated Show resolved Hide resolved

jaer-tsun reviewed Feb 4, 2019

View reviewed changes

cns/networkcontainers/networkcontainers_linux.go Outdated Show resolved Hide resolved

jaer-tsun reviewed Feb 4, 2019

View reviewed changes

cns/networkcontainers/networkcontainers_linux.go Outdated Show resolved Hide resolved

jaer-tsun reviewed Feb 4, 2019

View reviewed changes

cns/networkcontainers/networkcontainers_linux.go Show resolved Hide resolved

jaer-tsun reviewed Feb 4, 2019

View reviewed changes

cns/networkcontainers/networkcontainers_linux.go Outdated Show resolved Hide resolved

jaer-tsun reviewed Feb 4, 2019

View reviewed changes

cns/networkcontainers/networkcontainers_linux.go Outdated Show resolved Hide resolved

jaer-tsun reviewed Feb 4, 2019

View reviewed changes

cns/networkcontainers/networkcontainers_linux.go Outdated Show resolved Hide resolved

jaer-tsun reviewed Feb 4, 2019

View reviewed changes

cns/networkcontainers/networkcontainers_linux.go Outdated Show resolved Hide resolved

jaer-tsun reviewed Feb 4, 2019

View reviewed changes

cns/networkcontainers/networkcontainers_linux.go Outdated Show resolved Hide resolved

jaer-tsun reviewed Feb 4, 2019

View reviewed changes

cns/networkcontainers/networkcontainers_linux.go Outdated Show resolved Hide resolved

jaer-tsun reviewed Feb 4, 2019

View reviewed changes

cns/networkcontainers/networkcontainers_linux.go Outdated Show resolved Hide resolved

jaer-tsun reviewed Feb 4, 2019

View reviewed changes

cns/restserver/restserver.go Show resolved Hide resolved

jaer-tsun reviewed Feb 4, 2019

View reviewed changes

cns/networkcontainers/networkcontainers.go Outdated Show resolved Hide resolved

sharmasushant previously requested changes Feb 6, 2019

View reviewed changes

ninzavivek force-pushed the vivek_cns branch from 5d4f20a to 35b63c7 Compare February 7, 2019 21:54

ninzavivek force-pushed the vivek_cns branch from c437c52 to 60ad56b Compare March 7, 2019 02:17

ninzavivek requested a review from sharmasushant March 7, 2019 02:20

CNI Update operation support

78e47de

ninzavivek force-pushed the vivek_cns branch from 60ad56b to 78e47de Compare March 7, 2019 03:22

tamilmani1989 mentioned this pull request Mar 7, 2019

Added UT in telemetry code to fix code coverage #310

Merged

jaer-tsun reviewed Mar 11, 2019

View reviewed changes

Merge branch 'master' into vivek_cns

255aae4

jaer-tsun approved these changes Apr 10, 2019

View reviewed changes

ninzavivek merged commit 8434e95 into Azure:master Apr 10, 2019

ninzavivek deleted the vivek_cns branch April 10, 2019 21:21


		for testValue, expectedPodName := range testData {
		podName := GetPodNameWithoutSuffix(testValue)

Add support in CNS to perform CNI Update #296

Add support in CNS to perform CNI Update #296

Uh oh!

Conversation

ninzavivek commented Jan 30, 2019

Uh oh!

codecov bot commented Jan 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jaer-tsun Mar 11, 2019

Choose a reason for hiding this comment

Uh oh!

jaer-tsun Mar 11, 2019

Choose a reason for hiding this comment

Uh oh!

jaer-tsun left a comment

Choose a reason for hiding this comment

Uh oh!

jaer-tsun left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Jan 30, 2019 •

edited

Loading