fixed logging part of telemetry #312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #312 +/- ##
==========================================
- Coverage 46.51% 46.48% -0.03%
==========================================
Files 25 25
Lines 3440 3418 -22
==========================================
- Hits 1600 1589 -11
+ Misses 1600 1581 -19
- Partials 240 248 +8
Continue to review full report at Codecov.
|
…working into telemetry_logfix # Conflicts: # telemetry/telemetrybuffer.go
jaer-tsun
reviewed
Mar 13, 2019
Contributor
jaer-tsun
left a comment
jaer-tsun
left a comment
There was a problem hiding this comment.
I don't see changes to CNS telemetry here; will that be required? (for DNC as well?)
cni/network/plugin/main.go
Outdated
| log.Printf("[cni] Telemetry service started") | ||
|
|
||
| for attempt := 0; attempt < 5; attempt++ { | ||
| if telemetry.CheckIfSockExists() { |
Contributor
There was a problem hiding this comment.
telemetry.SockExists() ?
Why are there 5 attempts?
Member
Author
There was a problem hiding this comment.
just a calculated number. wait for second and then exit if telemetry socket doesn;t exist.
telemetry/telemetry_test.go
Outdated
| go tb.BufferAndPushData(0) | ||
| } | ||
|
|
||
| if !CheckIfSockExists() { |
jaer-tsun
approved these changes
Mar 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #This PR addresses
Special notes for your reviewer:
Release note: