Skip to content

Conversation

@ashvindeodhar
Copy link
Member

SDNRemoteArpMacAddress is the registry key for the remote mac address.
This is needed in case of multitenancy to get arp response from within VM.
This is achieved by setting In-VM arp responder that always responds with
a fake mac address.

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@codecov
Copy link

codecov bot commented Apr 12, 2019

Codecov Report

Merging #330 into master will increase coverage by 0.37%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #330      +/-   ##
==========================================
+ Coverage   45.16%   45.54%   +0.37%     
==========================================
  Files          25       25              
  Lines        3538     3509      -29     
==========================================
  Hits         1598     1598              
+ Misses       1685     1656      -29     
  Partials      255      255
Impacted Files Coverage Δ
telemetry/cnstelemetry.go 0% <0%> (ø) ⬆️
log/logger.go 56.47% <0%> (+1.92%) ⬆️
telemetry/telemetrybuffer.go 57.37% <0%> (+5.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc49b45...a3200d2. Read the comment docs.

Copy link
Contributor

@jaer-tsun jaer-tsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some general comments

@ashvindeodhar ashvindeodhar requested a review from jaer-tsun April 12, 2019 16:46
Copy link
Contributor

@jaer-tsun jaer-tsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ashvindeodhar ashvindeodhar merged commit a1f804a into Azure:master Apr 12, 2019
@ashvindeodhar ashvindeodhar deleted the ashvin-fork-SDNRemoteArpMacAddress branch April 29, 2019 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants