Added more features in iptm package #342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. ip6table cmd support 2. wiat falg with timeout
tamilmani1989
changed the title
tamilmani1989
changed the title
Codecov Report
@@ Coverage Diff @@
## master #342 +/- ##
==========================================
+ Coverage 45.18% 45.22% +0.04%
==========================================
Files 25 25
Lines 3539 3542 +3
==========================================
+ Hits 1599 1602 +3
Misses 1685 1685
Partials 255 255
Continue to review full report at Codecov.
|
saiyan86
suggested changes
Apr 24, 2019
|
|
||
| waitFlag := fmt.Sprintf("%s %s", util.IptablesWaitFlag, entry.LockWaitTimeInSeconds) | ||
| waitFlag = strings.TrimSpace(waitFlag) | ||
| cmdArgs := append([]string{waitFlag, iptMgr.OperationFlag, entry.Chain}, entry.Specs...) |
Contributor
There was a problem hiding this comment.
How about
append([]string{util.IptablesWaitFlag, entry.LockWaitTimeInSeconds, iptMgr.OperationFlag, entry.Chain}, entry.Specs...)
if you think the line is too long, we can line break too.
This way we don't need to import fmt & strings packages.
saiyan86
approved these changes
Apr 24, 2019
tamilmani1989
added a commit
that referenced
this pull request
Apr 24, 2019
This reverts commit 9cfec88.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds following support:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: