Fix cni logs #548
Merged
Fix cni logs #548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjohnst5
requested review from
ashvindeodhar,
neaggarwMS and
tamilmani1989
and removed request for
ashvindeodhar
neaggarwMS
reviewed
Apr 23, 2020
tamilmani1989
requested changes
Apr 29, 2020
tamilmani1989
requested changes
Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Empty CNI telemetry logs were being sent and cluttering jarvis. This PR disallows empty messages being sent.
Which issue this PR fixes
https://msazure.visualstudio.com/One/_workitems/edit/7041879
Special notes for your reviewer:
@tamilmani1989 , I tried adding a function in that defer call we were talking about yesterday, but it broke the connectivity of new pods. Opted for this simpler fix of just checking the error and event message for empty instead.