Removing execution time metric #566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #566 +/- ##
==========================================
+ Coverage 47.85% 49.19% +1.34%
==========================================
Files 27 28 +1
Lines 3281 3437 +156
==========================================
+ Hits 1570 1691 +121
- Misses 1434 1456 +22
- Partials 277 290 +13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR is to remove the CNIExecutionTimeMs metric from CNI because cni is using too much metrics data and this isn't a very informative metric and is causing lots of data usage from the Application Insights resources for our telemetry.
Special notes for your reviewer:
@tamilmani I tested the changes on an aks-engine cluster and the add and del metrics are unchanged, meaning the add and del metrics still show up in the metrics table in jarvis when adding and deleting pods