CRD: Move scaling items into scaler, change scope to namespaced #587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #587 +/- ##
==========================================
- Coverage 53.04% 53.00% -0.04%
==========================================
Files 23 23
Lines 2858 2858
==========================================
- Hits 1516 1515 -1
- Misses 1070 1071 +1
Partials 272 272 |
pjohnst5
reviewed
Jun 24, 2020
Contributor
pjohnst5
left a comment
pjohnst5
left a comment
There was a problem hiding this comment.
Just a comment asking if we can add "nnc" as a short name
neaggarwMS
approved these changes
Jun 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Changes CRD scope to Namespaced and groups together scaling-related items in status. Also, this adds the CRD manifest to the repo for quicker testing iteration.
Special notes for your reviewer:
Note that changing the scope of a CRD is not possible if the CRD already exists. To run this on a cluster that already has this CRD installed, you have to delete the CRD definition first before applying this one.