Add support for log file rotation #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sharmasushant
left a comment
sharmasushant
left a comment
There was a problem hiding this comment.
I think we should append timestamps to filenames when we start writing to the log file. When the file count goes beyond the limit, we should delete the file with oldest time stamp.
log/logger.go
Outdated
| const ( | ||
| logPrefix = "" | ||
| logFileExtension = ".log" | ||
| maxLogFileSize = 10 * 1024 * 1024 |
Contributor
There was a problem hiding this comment.
maxLogFileSizeInBytes
| logFileExtension = ".log" | ||
| maxLogFileSize = 10 * 1024 * 1024 | ||
| maxLogFileCount = 8 | ||
| rotationCheckFrq = 8 |
Contributor
There was a problem hiding this comment.
can we add units here too, rotationCheckFreqInCalls
log/logger_linux.go
Outdated
| const logFilePerm = os.FileMode(0664) | ||
|
|
||
| const syslogTag = "AzureContainerNet" | ||
| const syslogTag = "azure-vnet-plugin" |
Contributor
There was a problem hiding this comment.
I think the old name was better because CNS is not a vnet-plugin.
sharmasushant
approved these changes
Jun 14, 2017
Contributor
sharmasushant
left a comment
sharmasushant
left a comment
There was a problem hiding this comment.
Changes look good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rotates log files when they reach the size limit, keeps the last n files.