refactor: Move CNI bridge/transparent routes to common #694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #694 +/- ##
==========================================
- Coverage 39.12% 38.74% -0.39%
==========================================
Files 83 83
Lines 10697 10709 +12
==========================================
- Hits 4185 4149 -36
- Misses 6010 6056 +46
- Partials 502 504 +2 |
matmerr
commented
Oct 19, 2020
network/network_linux.go
Outdated
|
|
||
| return nil | ||
|
|
||
| // old |
matmerr
changed the title
matmerr
force-pushed
the
cnisnatrulecommon
branch
from
c0bba2e to
4931ccc
Compare
matmerr
commented
Oct 19, 2020
iptables/iptables.go
Outdated
| DisableIPTableLock bool | ||
| ) | ||
|
|
||
| type IpTableEntry struct { |
matmerr
commented
Nov 11, 2020
cni/network/invoker_cns.go
Outdated
| } | ||
|
|
||
| azureDNSMatch := fmt.Sprintf(" -m addrtype ! --dst-type local -s %s -d %s -p %s --dport %d", ncSubnetPrefix.String(), iptables.AzureDNS, iptables.UDP, iptables.DNSPort) | ||
| snatPrimaryIPJump := fmt.Sprintf("%s --to %s", iptables.Snat, info.podIPAddress) |
Member
Author
There was a problem hiding this comment.
info.podIPAddress don't snat with podIPAddress, snat with ncPrimaryIPAddress
vakalapa
reviewed
Nov 13, 2020
matmerr
force-pushed
the
cnisnatrulecommon
branch
from
4931ccc to
45817d1
Compare
vakalapa
approved these changes
Nov 13, 2020
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Fixed an issue for adding routes to the external interface, in transparent and bridge mode, as well as the snat rules
Issue Fixed:
Requirements:
Notes: