Add nc version in SecondaryIPConfig structure. #697
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #697 +/- ##
==========================================
+ Coverage 38.56% 38.58% +0.02%
==========================================
Files 79 79
Lines 10447 10451 +4
==========================================
+ Hits 4029 4033 +4
Misses 5926 5926
Partials 492 492 |
neaggarwMS
reviewed
Oct 22, 2020
neaggarwMS
reviewed
Oct 22, 2020
Contributor
Author
|
Open a new PR with master merged in #701 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Add NC version in SecondaryIPConfig structure.
Reason for Change:
When CNS reconcile, it needs NC version to determine whether an IP should be stay in pending programming or available.