Skip to content

Conversation

@matmerr
Copy link
Member

@matmerr matmerr commented Oct 28, 2020

Reason for Change:

Need to generate a CNI tarball with a swift conflist, where the CNI mode is azure-cns

Issue Fixed:

Requirements:

Notes:

@matmerr matmerr requested a review from vakalapa October 28, 2020 23:23
@codecov
Copy link

codecov bot commented Oct 28, 2020

Codecov Report

Merging #711 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #711      +/-   ##
==========================================
- Coverage   38.62%   38.54%   -0.08%     
==========================================
  Files          79       79              
  Lines       10471    10471              
==========================================
- Hits         4044     4036       -8     
- Misses       5938     5943       +5     
- Partials      489      492       +3     

Copy link
Contributor

@vakalapa vakalapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@matmerr matmerr merged commit 3eb5f3c into Azure:master Oct 29, 2020
@matmerr matmerr deleted the swiftmakefile branch October 29, 2020 17:32
matmerr added a commit that referenced this pull request Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants