CNS_Fixing debug API #808
Merged
CNS_Fixing debug API #808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
csfmomo
reviewed
Mar 2, 2021
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov Report
@@ Coverage Diff @@
## master #808 +/- ##
==========================================
- Coverage 42.34% 42.32% -0.03%
==========================================
Files 144 144
Lines 14191 14191
==========================================
- Hits 6009 6006 -3
- Misses 7456 7459 +3
Partials 726 726 |
kmurudi
assigned
kmurudi,
matmerr and
neaggarwMS and unassigned
kmurudi,
matmerr and
neaggarwMS
matmerr
reviewed
Mar 2, 2021
cns/restserver/ipam.go
Outdated
| ID: v.ID, | ||
| } | ||
| vsf = append(vsf, ip) | ||
| vsf = append(vsf, ipconfigstate) |
Member
There was a problem hiding this comment.
since the filter type is the same as the return type, we can append v here instead of copying to a new struct ipconfigstate
matmerr
reviewed
Mar 2, 2021
matmerr
reviewed
Mar 2, 2021
neaggarwMS
reviewed
Mar 2, 2021
| IPConfigStateFilter []string | ||
| } | ||
|
|
||
| // GetIPAddressStateResponse is used in CNS IPAM mode as a response to get IP address state |
Member
There was a problem hiding this comment.
Is this only used for debug API and not any other scenario like ACI/Batch? @matmerr ?
neaggarwMS
reviewed
Mar 2, 2021
Member
The GetIPAddressesMatchingStates now returns IPConfigurationStatus type, which also includes PodInfo along with IP address and state fix : minor formatting
GetIPAddressStateResponse kept as original struct, and added GetIPAddressStatusResponse Minor changes to reflect GetIPAddressStatusResponse
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GetIPAddressesMatchingStates now returns IPConfigurationStatus
type, which also includes PodInfo along with IP address and state
Reason for Change:
Issue Fixed:
Requirements:
Notes: