Skip to content

Conversation

@vakalapa
Copy link
Contributor

Reason for Change:

Issue Fixed:

Requirements:

Notes:

@vakalapa vakalapa added the npm Related to NPM. label Mar 11, 2021
@codecov
Copy link

codecov bot commented Mar 11, 2021

Codecov Report

Merging #820 (f93a3a2) into master (d169929) will decrease coverage by 0.25%.
The diff coverage is 35.15%.

@@            Coverage Diff             @@
##           master     #820      +/-   ##
==========================================
- Coverage   42.18%   41.92%   -0.26%     
==========================================
  Files         152      152              
  Lines       14335    14373      +38     
==========================================
- Hits         6047     6026      -21     
- Misses       7561     7616      +55     
- Partials      727      731       +4     

@vakalapa vakalapa marked this pull request as ready for review March 12, 2021 17:57
timer = metrics.StartNewTimer()
hashedSelector = HashSelector(&npObj.Spec.PodSelector)
npKey = GetNetworkPolicyKey(npObj)
npProcessedKey = GetProcessedNPKey(npObj, hashedSelector)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the difference between processed NP key and raw NP policy, why cant they be same?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

processed Key is based on the pod selector, if different netpols with different names have same pod selector, we are creating a single processedNp aggregating all the rules for the podselector on which we are applying

Copy link
Member

@neaggarwMS neaggarwMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@vakalapa vakalapa merged commit 455f5cb into master Mar 15, 2021
@vakalapa vakalapa deleted the vakr/decoupleresourcemaps branch March 15, 2021 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

npm Related to NPM.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants