-
Notifications
You must be signed in to change notification settings - Fork 260
[NPM] Decoupling resource cache maps from NSmap #820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #820 +/- ##
==========================================
- Coverage 42.18% 41.92% -0.26%
==========================================
Files 152 152
Lines 14335 14373 +38
==========================================
- Hits 6047 6026 -21
- Misses 7561 7616 +55
- Partials 727 731 +4 |
| timer = metrics.StartNewTimer() | ||
| hashedSelector = HashSelector(&npObj.Spec.PodSelector) | ||
| npKey = GetNetworkPolicyKey(npObj) | ||
| npProcessedKey = GetProcessedNPKey(npObj, hashedSelector) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the difference between processed NP key and raw NP policy, why cant they be same?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
processed Key is based on the pod selector, if different netpols with different names have same pod selector, we are creating a single processedNp aggregating all the rules for the podselector on which we are applying
neaggarwMS
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![]()
Reason for Change:
Issue Fixed:
Requirements:
Notes: