Skip to content

Conversation

@pjohnst5
Copy link
Contributor

@pjohnst5 pjohnst5 commented Apr 2, 2021

Reason for Change:
Adding a max ip count to the CRD scaler

@codecov
Copy link

codecov bot commented Apr 2, 2021

Codecov Report

Merging #846 (8ac11d9) into master (9365272) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #846   +/-   ##
=======================================
  Coverage   42.10%   42.10%           
=======================================
  Files         158      158           
  Lines       15025    15025           
=======================================
  Hits         6327     6327           
  Misses       7926     7926           
  Partials      772      772           

@thatmattlong
Copy link
Collaborator

Did you run make generate? I would expect there to be a small change to zz_deepcopy file

@pjohnst5
Copy link
Contributor Author

pjohnst5 commented Apr 5, 2021

@thatmattlong yeah I ran make and make generate just in case, no change

root[nodenetworkconfig](crd-scaler-changes) make
go: found sigs.k8s.io/controller-tools/cmd/controller-gen in sigs.k8s.io/controller-tools v0.3.0
controller-gen object:headerFile="boilerplate.go.txt" paths="./..."
root[nodenetworkconfig](crd-scaler-changes) make generate
go: found sigs.k8s.io/controller-tools/cmd/controller-gen in sigs.k8s.io/controller-tools v0.3.0
controller-gen object:headerFile="boilerplate.go.txt" paths="./..."

@pjohnst5
Copy link
Contributor Author

pjohnst5 commented Apr 5, 2021

Here's PR from the past that also added a field to the NNC, I don't see any changes in zz_copy from it so I think it worked how its supposed to
35e768e#diff-11d6b4c2fcf55d2b9bbac5cf03e2e766c985340b3f42beef896e7af14d084cb6

@pjohnst5 pjohnst5 merged commit cf7d8a5 into Azure:master Apr 5, 2021
@pjohnst5 pjohnst5 deleted the crd-scaler-changes branch April 5, 2021 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants