Add multi-tenant NetworkContainer controller #876
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feiskyer
force-pushed
the
multietenant-controller
branch
3 times, most recently
from
462e568 to
14cf9c3
Compare
levimm
previously approved these changes
May 28, 2021
cns/multitenantcontroller/multitenantoperator/multitenantcrdcontroller.go
Show resolved
Hide resolved
thatmattlong
reviewed
Jun 2, 2021
cns/multitenantcontroller/multitenantoperator/multitenantcrdreconciler.go
Show resolved
Hide resolved
Collaborator
|
Hey @feiskyer there are some merge conflicts in the makefile, after you are able to resolve I will approve |
feiskyer
force-pushed
the
multietenant-controller
branch
from
14cf9c3 to
4d88a01
Compare
Member
Author
|
@thatmattlong rebased the PR |
feiskyer
force-pushed
the
multietenant-controller
branch
from
4d88a01 to
aa3e8c3
Compare
thatmattlong
approved these changes
Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
This PR adds multi-tenant NetworkContainer controller, which includes:
It also splits the original
CreateOrUpdateNC()into two functionCreateOrUpdateNC()andUpdateIPAMPoolMonitor(), so that the newCreateOrUpdateNC()interface could be reused across different CRD reconcilers.Issue Fixed:
Requirements:
Notes: